Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: write planfile even on empty plans #4766

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Jan 20, 2016

This makes the planfile workflow more consistent. If a plan yields a
noop, the apply of that planfile will noop.

Fixes #1783

This makes the planfile workflow more consistent. If a plan yields a
noop, the apply of that planfile will noop.

Fixes #1783
@jen20
Copy link
Contributor

jen20 commented Jan 20, 2016

LGTM.

phinze added a commit that referenced this pull request Jan 20, 2016
@phinze phinze merged commit 859bea5 into master Jan 20, 2016
@phinze phinze deleted the phinze/write-empty-planfiles branch January 20, 2016 22:49
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected "apply" not to do anything, but creates duplicate
2 participants